Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sorbet version used in tests #404

Closed
egiurleo opened this issue Jun 21, 2023 · 0 comments · Fixed by #406
Closed

Fix Sorbet version used in tests #404

egiurleo opened this issue Jun 21, 2023 · 0 comments · Fixed by #406
Assignees
Labels
chore Chore task

Comments

@egiurleo
Copy link
Contributor

Problem
The spoom Gemfile does not lock the version of Sorbet, so by default bundler installs the latest version of Sorbet on every test run. This can cause test failures that are unrelated to a given PR (see this example), which is confusing and blocks us from merging PRs without breaking changes.

Solution
Let's fix the Sorbet version used in tests to the one listed in Gemfile.lock (here's how we do it in Tapioca). Any breaking change in Sorbet will only cause the tests to fail when Sorbet is bumped, which is much easier to track and fix than with our current approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore task
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant