Tapioca generated RBI for spoom 1.2.2 fails typechecking

[jesse-shopify]

Describe the bug
Upgrading from spoom 1.2.1 to 1.2.2 produces errors when the RBI file is regenerated using tapioca.

There are 74 errors but all seem to stem from these 2 causes:

• Unable to resolve constant SyntaxTree
• Spoom::Deadcode::Indexer#... is marked override but does not override anything

To Reproduce
Spoom version: 1.2.2

Steps to reproduce the behavior:

1. bundle exec tapioca gem spoom
2. bundle exec srb

Expected behavior

In version 1.2.1 srb completes with no errors.

[Morriar]

👋 Hey @jesse-shopify,

Can you try to add require "syntax_tree" in your sorbet/tapioca/require.rb file and run tapioca gem again please? 🙏

[jesse-shopify]

Thanks! I found the solution. It is because I already had the latest syntax_tree (and thus prettier_print) RBI files, so they didn't get regenerated when spoom was updated. This fixed it:

bundle exec tapioca gem syntax_tree prettier_print spoom

[michaelherold]

We had the same issue and Jesse's fix was required. require "syntax_tree" doesn't do anything because it's the older RBIs that cause the problem.

This makes me wonder if, when updating Tapioca, we should always regenerate all RBIs?

[andyw8]

It's a good practice to do so, but it's time-consuming. We're working on more automation to help with this.