Add minitest backtrace filter #457
Conversation
README.md
Outdated
|
|
||
| ```ruby | ||
| # test/test_helper.rb | ||
| require "spoom/minitest/backtrace_filter" |
There was a problem hiding this comment.
(wondering where this should be a manual require or not)
andyw8
force-pushed
the
andyw8/add-minitest-backtrace-filter
branch
from
8abfb97 to
5ee258a
Compare
|
|
||
| module Spoom | ||
| module BacktraceFilter | ||
| class Minitest < ::Minitest::BacktraceFilter |
There was a problem hiding this comment.
I originally had Spoom::Minitest::BacktraceFilter but that causes typecheck problems with tests in the Spoom namespace that inherit from Minitest::Test.
There was a problem hiding this comment.
TODO: rename the file to match the updated naming
There was a problem hiding this comment.
We can change the tests to inherit from ::Minitest::Test if you prefer the other name 👍
There was a problem hiding this comment.
I think this way is ok, have renamed the file to match.
lib/spoom.rb
Outdated
| @@ -18,4 +18,5 @@ class Error < StandardError; end | |||
| require "spoom/deadcode" | |||
| require "spoom/sorbet" | |||
| require "spoom/cli" | |||
| require "spoom/minitest/backtrace_filter" | |||
There was a problem hiding this comment.
I'd make this require manual and not included in the default require.
andyw8
force-pushed
the
andyw8/add-minitest-backtrace-filter
branch
2 times, most recently
from
6719295 to
79987ce
Compare
|
Here's a Ruby LSP branch using this, for verification: https://github.com/Shopify/ruby-lsp/pull/965/files Note that we need to add an entry to |
andyw8
force-pushed
the
andyw8/add-minitest-backtrace-filter
branch
from
79987ce to
0c0163e
Compare
Closes #456