Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorbet_removal_commit doesn't take into account a re-addition #465

Closed
KaanOzkan opened this issue Sep 18, 2023 · 1 comment
Closed

sorbet_removal_commit doesn't take into account a re-addition #465

KaanOzkan opened this issue Sep 18, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@KaanOzkan
Copy link
Contributor

KaanOzkan commented Sep 18, 2023

Spoom incorrectly displays that a project has removed sorbet

The logic could check if sorbet/config has been introduced again since it's been removed (intro date > removal date) and not populate removal_commit.

@KaanOzkan KaanOzkan added the bug Something isn't working label Sep 18, 2023
@Morriar
Copy link
Collaborator

Morriar commented Sep 19, 2023

I'm not sure I agree with this issue.

The library does its job and correctly tells you when the sorbet/config file was removed for the last time from Git index.

I think it's up to the library client to do what makes sense with this information and compare both the last intro date and last removal date.

@Morriar Morriar closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants