Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead code plugin for sorbet should consider RBS comments for override #649

Open
Morriar opened this issue Feb 24, 2025 · 0 comments
Open
Labels
bug Something isn't working

Comments

@Morriar
Copy link
Collaborator

Morriar commented Feb 24, 2025

During dead code detection we currently ignore methods marked as override in their sig block so this method won't be marked as dead:

sig { override.void }
def foo; end

Now that we migrated to RBS signature comments, the equivalent signature is considered dead:

# @overrride
#: -> void
def foo; end

We'll need to consider RBS signatures comments in this plugin.

@Morriar Morriar added the bug Something isn't working label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant