Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dead code ignore methods marked as @override or @overridable #657

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

Morriar
Copy link
Collaborator

@Morriar Morriar commented Feb 26, 2025

Now that we're using RBS signature comments, method marked @override or @overridable such as this one, shouldn't be considered dead:

# @override
@: -> void
def foo; end

Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
Signed-off-by: Alexandre Terrasa <alexandre.terrasa@shopify.com>
@Morriar Morriar added the feature New feature label Feb 26, 2025
@Morriar Morriar self-assigned this Feb 26, 2025
@Morriar Morriar requested a review from a team as a code owner February 26, 2025 16:15
@Morriar Morriar merged commit 4aa8479 into main Feb 26, 2025
8 checks passed
@Morriar Morriar deleted the at-parse-comments branch February 26, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants