Add command to translate some inline type annotations to RBS comments #658
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add translation of
T.let
when found in an assign to RBS comments.This:
is translated into:
Note that we only support translation in assigns for local, global, instance, class variables, constants and constant paths.
Annotations not in an assign node are ignored:
We also try our best to make the resulting code pass style checks and reindent properly:
is thus rewrote as:
This is still experimental as I'm sure we're missing a bunch of edge-cases but that should be enough to get us started.
Here are two examples running this tool on other open-source projects: