Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update syntaxes submodule to latest commit #653

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

EvilGenius13
Copy link
Contributor

@EvilGenius13 EvilGenius13 commented Dec 5, 2024

What are you adding in this PR?

We have recently introduced syntax highlighting for the liquid doc tag in the liquid-tm-grammar repo. This PR updates the submodule commit in /vscode-extension/syntaxes to point to the latest commit

What's next? Any followup issues?

What did you learn?

Before you deploy

  • This PR includes a new checks or changes the configuration of a check
    • I included a minor bump changeset
    • It's in the allChecks array in src/checks/index.ts
    • I ran yarn build and committed the updated configuration files
      • If applicable, I've updated the theme-app-extension.yml config
  • I included a minor bump changeset
  • My feature is backward compatible
  • I included a patch bump changeset

@EvilGenius13 EvilGenius13 marked this pull request as ready for review December 5, 2024 20:23
Copy link
Contributor

I think we're ok without a changeset since we don't have official support for LiquidDoc yet, but will defer to CP on that

@charlespwd
Copy link
Collaborator

I think the rule should be to always have a changeset.

Anything on main that implicitly depends on something without a changeset is a bug-in-production risk. See #161

it won't happen in this particular case, but it shouldn't become a habit.

@charlespwd
Copy link
Collaborator

Also, I think we should wait till the tag is supported to syntax highlight it? OW we might give the impression that it's supported but it isn't.

@EvilGenius13
Copy link
Contributor Author

Also, I think we should wait till the tag is supported to syntax highlight it? OW we might give the impression that it's supported but it isn't.

That makes sense. I'll add a changeset and we can ship it when the tag itself is ready.

@EvilGenius13 EvilGenius13 force-pushed the update-syntaxes-module branch from bdfff67 to 8dafe7a Compare December 6, 2024 15:50
@EvilGenius13 EvilGenius13 added the #gsd:44310 LiquidDoc label Feb 5, 2025
Co-authored-by: Alok Swamy <alok.swamy@shopify.com>
@EvilGenius13 EvilGenius13 force-pushed the update-syntaxes-module branch from 8dafe7a to d190935 Compare March 3, 2025 19:29
@EvilGenius13 EvilGenius13 requested a review from a team as a code owner March 3, 2025 19:29
@EvilGenius13 EvilGenius13 merged commit 898fdc1 into main Mar 3, 2025
7 checks passed
@EvilGenius13 EvilGenius13 deleted the update-syntaxes-module branch March 3, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:44310 LiquidDoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants