Add type checking support for render snippets using alias syntax #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 28, 2025
jamesmengo
force-pushed
the
jm/alias_typechecks
branch
from
a70301c to
46e674a
Compare
jamesmengo
requested review from
aswamy and
a team
and removed request for
a team
jamesmengo
force-pushed
the
jm/alias_unrecognized_params
branch
2 times, most recently
from
99aba80 to
2135423
Compare
jamesmengo
force-pushed
the
jm/alias_typechecks
branch
from
46e674a to
bd60958
Compare
aswamy
approved these changes
Feb 28, 2025
packages/theme-check-common/src/checks/valid-render-snippet-param-types/index.ts
Outdated
Show resolved
Hide resolved
jamesmengo
changed the base branch from
jm/alias_unrecognized_params
to
graphite-base/833
jamesmengo
force-pushed
the
jm/alias_typechecks
branch
from
bd60958 to
6f3ed90
Compare
- Extend ValidRenderSnippetParamTypes to handle `with/as` alias scenarios
jamesmengo
force-pushed
the
jm/alias_typechecks
branch
from
6f3ed90 to
48d4d79
Compare
… check if default value is empty. This applies to object types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Closes https://github.com/Shopify/developer-tools-team/issues/606
Type checking support when the
rendertag is using awith/foralias syntaxThis also skips type comparisons when the variable value is a VariableLookup. That's definitely functionality that we want to expand. Issue Link
Before you deploy
changeset