Fix file URI handling for Windows platforms #835
Merged
+28
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvilGenius13
force-pushed
the
fix-windows-uri
branch
from
3ff98df to
067feb7
Compare
graygilmore
reviewed
Mar 11, 2025
| // start with a drive letter (with few exceptions we can ignore). | ||
| // More info: https://learn.microsoft.com/en-us/dotnet/standard/io/file-path-formats | ||
| // | ||
| // If an absoluate path starts with a slash on Windows, we strip it |
There was a problem hiding this comment.
Could we add a test for this? Is there a reasonable way to accomplish that?
There was a problem hiding this comment.
Could we add a test for this?
Will do!
Is there a reasonable way to accomplish that?
We can't tophat this in a reasonable way because we have to release theme-tools FIRST then update CLI. To verify this works i installed CLI on my windows machine, then updated its source code to contain this change.
graygilmore
approved these changes
Mar 11, 2025
aswamy
force-pushed
the
fix-windows-uri
branch
3 times, most recently
from
164cc92 to
16ad83d
Compare
Co-authored-by: Josh Faigan <josh.faigan@shopify.com>
Force push
Built in function: |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Part of Shopify/cli#3497
After a long debugging session and some async work with @aswamy, we found where the issue was coming from.
On windows platforms, filepaths look something like this
file:\\\C:\path\to\file.asyncGlobon Windows, it gets confused because of the leading//if it exists before a pathThis implementation checks if the OS is windows before changing the way we change the URI to ensure we don't affect unix based systems.
Before you deploy
changeset