[LiquidDoc] Show annotation completion suggestions when @ is typed
#839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmengo
changed the title
@ as a completions trigger character
jamesmengo
changed the title
jamesmengo
changed the title
@ is typed
jamesmengo
force-pushed
the
jm/add_completions_trigger
branch
from
f235c67 to
1dc0317
Compare
jamesmengo
requested review from
aswamy and
EvilGenius13
and removed request for
a team
aswamy
approved these changes
Mar 5, 2025
EvilGenius13
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
Closes https://github.com/Shopify/developer-tools-team/issues/613
Renders completion suggestion for
liquidDocannotations while typingCursor - [Extension Development Host] mega-menu.liquid — horizon.mp4 (uploaded via Graphite)
What did you learn?
Before you deploy
changeset