Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix liquid doc node hover text #841

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Fix liquid doc node hover text #841

merged 1 commit into from
Mar 5, 2025

Conversation

aswamy
Copy link
Contributor

@aswamy aswamy commented Mar 5, 2025

What are you adding in this PR?

  • Fix bug where hover text appears when hovering over liquid doc nodes that aren't just node names

NOTE: The hover text won't appear when your cursor is just on @ symbol. This is just because of our liquid syntax rules.
image

Before you deploy

  • I included a patch bump changeset

@aswamy aswamy requested a review from a team as a code owner March 5, 2025 16:13
@aswamy aswamy added the #gsd:44310 LiquidDoc label Mar 5, 2025
EvilGenius13
EvilGenius13 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@EvilGenius13 EvilGenius13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩and it feels much better! 👍

@aswamy aswamy merged commit cb2b2f4 into main Mar 5, 2025
7 checks passed
@aswamy aswamy deleted the fix-liquid-doc-tag-hover branch March 5, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvilGenius13 EvilGenius13

@jamesmengo jamesmengo

Assignees
No one assigned
Labels
#gsd:44310 LiquidDoc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aswamy @EvilGenius13