Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming liquid doc params refactors render tag params #843

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Renaming liquid doc params refactors render tag params #843

merged 1 commit into from
Mar 6, 2025

Conversation

aswamy
Copy link
Contributor

@aswamy aswamy commented Mar 6, 2025

What are you adding in this PR?

Part 1 of https://github.com/Shopify/developer-tools-team/issues/616

By renaming liquid doc params, we also refactor the render tag named params

  • Next PR will also update alias
    • with 'literal' as foo
    • with variable as foo
    • for 'literal' as foo
    • for variable as foo

Before you deploy

  • I included a minor bump changeset
  • My feature is backward compatible

@aswamy aswamy requested a review from a team as a code owner March 6, 2025 16:46
EvilGenius13
EvilGenius13 approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@EvilGenius13 EvilGenius13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I tried adding a param in as many places as I could that shouldn't change and couldn't find an error.

@aswamy aswamy merged commit 22dd956 into main Mar 6, 2025
7 checks passed
@aswamy aswamy deleted the param-rename-updates-render-params branch March 6, 2025 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvilGenius13 EvilGenius13

@jamesmengo jamesmengo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aswamy @EvilGenius13