Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming liquid doc params refactors render tag alias param #844

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

aswamy
Copy link
Contributor

@aswamy aswamy commented Mar 6, 2025

What are you adding in this PR?

Part 2 of https://github.com/Shopify/developer-tools-team/issues/616
Closes https://github.com/Shopify/developer-tools-team/issues/616

By renaming liquid doc params, we also refactor the render tag alias.

Example:

  • render 'example-snippet' with 'literal' as foo
  • render 'example-snippet' with variable as foo
  • render 'example-snippet' for 'literal' as foo
  • render 'example-snippet' for variable as foo
Screen.Recording.2025-03-06.at.12.04.50.PM.mov

Before you deploy

  • I included a minor bump changeset
  • My feature is backward compatible

@aswamy aswamy requested a review from a team as a code owner March 6, 2025 16:55
Copy link
Contributor

@EvilGenius13 EvilGenius13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩 (with some backup) and everything worked on my end!

Base automatically changed from param-rename-updates-render-params to main March 6, 2025 21:03
@aswamy aswamy force-pushed the param-rename-updates-render-alias branch from 53ec5c7 to df4c189 Compare March 6, 2025 21:05
@aswamy aswamy added the #gsd:44310 LiquidDoc label Mar 6, 2025
@aswamy aswamy merged commit 17cf30d into main Mar 6, 2025
7 checks passed
@aswamy aswamy deleted the param-rename-updates-render-alias branch March 6, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#gsd:44310 LiquidDoc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants