-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update onboarding UX, adding new tasks #70
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradkratky-shop
commented
Mar 11, 2025
bradkratky-shop
commented
Mar 11, 2025
bradkratky-shop
commented
Mar 11, 2025
bradkratky-shop
commented
Mar 11, 2025
bradkratky-shop
commented
Mar 11, 2025
bradkratky-shop
commented
Mar 11, 2025
bradkratky-shop
commented
Mar 11, 2025
bradkratky-shop
commented
Mar 11, 2025
bradkratky-shop
commented
Mar 11, 2025
lfroms
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change accomplish?
This is an update to the Onboarding splash screen. This new version adds additional tasks to the Xcode and Android Studio set up to provide more detailed instructions for how to install the necessary tools. To accommodate the new tasks, the layout has also been modified.
Video of incomplete tasks (mocked):
Screen.Recording.2025-02-12.at.3.24.13.PM.mov
New task links:
How have you achieved it?
How can the change be tested?
The easiest way is to checkout the branch and make local modifications to force the onboarding screen to load:
isComplete
to false in the following files:a.
AndroidStudioOnboardingItem
b.
AndroidSDKsOnboardingItem
c.
AndroidEmulatorsOnboardingItem
d.
XcodeOnboardingItem
e.
XcodeSimulatorSDKsOnboardingItem
f.
XcodeCommandLineToolsOnboardingItem