Create rule S7200: Avoid resizing a vector to zero using vec.resize(0, value)
#4677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
yassin-kammoun-sonarsource
changed the title
vec.resize(0, value)
yassin-kammoun-sonarsource
force-pushed
the
rule/add-RSPEC-S7200
branch
from
0df66fa to
d8aaa9d
Compare
sallaigy
approved these changes
Feb 24, 2025
rules/S7200/rust/metadata.json
Outdated
Comment on lines
3
to
21
| "type": "CODE_SMELL", | ||
| "status": "ready", | ||
| "remediation": { | ||
| "func": "Constant\/Issue", | ||
| "constantCost": "5min" | ||
| }, | ||
| "tags": [ | ||
| "clippy", | ||
| "vec_resize_to_zero" | ||
| ], | ||
| "defaultSeverity": "Major", | ||
| "ruleSpecification": "RSPEC-7200", | ||
| "sqKey": "S7200", | ||
| "scope": "All", | ||
| "defaultQualityProfiles": ["Sonar way"], | ||
| "quickfix": "unknown", | ||
| "code": { | ||
| "impacts": { | ||
| "MAINTAINABILITY": "LOW" |
There was a problem hiding this comment.
This rule seems like a correctness issue to me and not merely a code smell. If you write vec.resize(0, 5) (a vector of size 0) and meant vec.resize(5, 0) (a vector with a size of 5 possibly extended with zeros) this will be a bug. What do you think?
There was a problem hiding this comment.
Yes, you are absolutely right. I will change the type to bug.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: