Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SONARJAVA-4972 S1118 Fix FPs on Lombok annotations in automatic analysis #5035

Merged
merged 11 commits into from
Mar 5, 2025
Merged

SONARJAVA-4972 S1118 Fix FPs on Lombok annotations in automatic analysis #5035

merged 11 commits into from
Mar 5, 2025

Conversation

tomasz-tylenda-sonarsource
Copy link
Contributor

@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource commented Feb 17, 2025 •
edited by jira bot
Loading

dorian-burihabwa-sonarsource
dorian-burihabwa-sonarsource requested changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks pretty good already but I see that the ticket mentions access level NONE. Whether we decide to consider it as TP or FP, we should probably add an example in the tests

@sonarqube-next SonarQube-Next
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2025

This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically

@github-actions github-actions bot added the stale label Mar 1, 2025
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource merged commit ca4993a into master Mar 5, 2025
19 checks passed
@tomasz-tylenda-sonarsource tomasz-tylenda-sonarsource deleted the tt/S1118-fp-lombok-autoscan branch March 5, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomasz-tylenda-sonarsource @dorian-burihabwa-sonarsource