SONARJAVA-5232 S1192 Relax duplicate string check for Throwable arguments #5036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasz-tylenda-sonarsource
requested a review
from dorian-burihabwa-sonarsource
|
|
This PR is stale because it has been open 7 days with no activity. If there is no activity in the next 7 days it will be closed automatically |
dorian-burihabwa-sonarsource
requested changes
Mar 5, 2025
There was a problem hiding this comment.
This looks good overall but before merging, it would make sense to:
- Document the last suggested case with exceptions constructed and then thrown
- Squash the PR into a single commit
- Rewrite the commit message to be very explicit in the fact that this change is a relaxation of the existing rule
java-checks-test-sources/default/src/main/java/checks/StringLiteralDuplicatedCheckSample.java
Show resolved
Hide resolved
This change addresses false positives reported on SonarCloud. Throwable arguments are intended for human readability, making constant extraction unnecessary. Therefore, we no longer report duplication in these cases. This change also accounts for corner cases where a string used in a Throwable has an existing constant or is also used in another context.
tomasz-tylenda-sonarsource
force-pushed
the
tt-S1192-exceptions-with-constants
branch
from
c74a3fe to
a60893c
Compare
tomasz-tylenda-sonarsource
changed the title
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SONARJAVA-5232
Previously #4984 and #5006