Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLI-1886 AI CodeFix improvements #1322

Merged
merged 9 commits into from
Mar 5, 2025

Conversation

nquinquenel
Copy link
Member

@nquinquenel nquinquenel commented Feb 24, 2025

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title AI CodeFix improvements SLI-1886 AI CodeFix improvements Feb 24, 2025
@nquinquenel nquinquenel force-pushed the feature/nq/ai-codefix-improvements branch 2 times, most recently from e7a1016 to 0e2384e Compare February 28, 2025 14:27
@nquinquenel nquinquenel force-pushed the feature/nq/ai-codefix-improvements branch from c5b994f to 405d415 Compare March 4, 2025 10:29
@nquinquenel nquinquenel force-pushed the feature/nq/ai-codefix-improvements branch from f050368 to b5069c8 Compare March 4, 2025 15:00
@nquinquenel nquinquenel marked this pull request as ready for review March 4, 2025 15:18
Copy link
Contributor

@damien-urruty-sonarsource damien-urruty-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good but I have a doubt about a possible memory leak


private const val HIGHLIGHT_GROUP_ID = 1001

@Service(Service.Level.PROJECT)
class EditorDecorator(private val project: Project) {
private val currentHighlightedDoc: HashSet<Document> = hashSetOf()
private val currentGutterIcons: HashSet<RangeHighlighter> = hashSetOf()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it normal that we only add stuff in this list and never remove anything?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, the whole management was not ideal, I reworked this

Copy link

sonarqube-next bot commented Mar 4, 2025

@nquinquenel nquinquenel merged commit 4c2d8fa into master Mar 5, 2025
31 checks passed
@nquinquenel nquinquenel deleted the feature/nq/ai-codefix-improvements branch March 5, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants