-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SLI-1886 AI CodeFix improvements #1322
Conversation
e7a1016
to
0e2384e
Compare
c5b994f
to
405d415
Compare
f050368
to
b5069c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good but I have a doubt about a possible memory leak
src/main/java/org/sonarlint/intellij/actions/SuggestCodeFixIntentionAction.kt
Outdated
Show resolved
Hide resolved
|
||
private const val HIGHLIGHT_GROUP_ID = 1001 | ||
|
||
@Service(Service.Level.PROJECT) | ||
class EditorDecorator(private val project: Project) { | ||
private val currentHighlightedDoc: HashSet<Document> = hashSetOf() | ||
private val currentGutterIcons: HashSet<RangeHighlighter> = hashSetOf() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it normal that we only add stuff in this list and never remove anything?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, the whole management was not ideal, I reworked this
src/main/java/org/sonarlint/intellij/ui/codefix/CodeFixTabPanel.kt
Outdated
Show resolved
Hide resolved
|
SLI-1886