Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SLI-1888 IntelliJ Walkthrough #1323

Merged
merged 1 commit into from
Mar 6, 2025
Merged

SLI-1888 IntelliJ Walkthrough #1323

merged 1 commit into from
Mar 6, 2025

Conversation

eray-felek-sonarsource
Copy link
Contributor

@eray-felek-sonarsource eray-felek-sonarsource commented Feb 26, 2025 •
edited by jira bot
Loading

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title IntelliJ Walkthrough SLI-1888 IntelliJ Walkthrough Feb 26, 2025
@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/intellij-walkthrough branch from 99a4f7c to 4c8d6e9 Compare February 26, 2025 08:10
nquinquenel
nquinquenel requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly some comments about the structure and organization of the tool window creation.

Otherwise the content itself LGTM

@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/intellij-walkthrough branch 2 times, most recently from 67b07a1 to a94741a Compare February 27, 2025 10:25
@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/intellij-walkthrough branch from a94741a to cec0a69 Compare February 27, 2025 10:55
nquinquenel
nquinquenel requested changes Feb 27, 2025
View reviewed changes
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could reduce the overall complexity, and make the structure cleaner. Otherwise it seems functional.

It is planned to have the possibility to open a file during the onboarding, which premade issues, so the user can try raising an issue?

@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/intellij-walkthrough branch from cec0a69 to 5c219e8 Compare February 27, 2025 13:16
@nquinquenel nquinquenel force-pushed the feature/ef/intellij-walkthrough branch from d109b64 to 9659df7 Compare February 28, 2025 08:05
@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/intellij-walkthrough branch from 9659df7 to 93f7cda Compare February 28, 2025 08:41
nquinquenel
nquinquenel reviewed Feb 28, 2025
View reviewed changes
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is the final version of the text, is it? It doesn't fit SQ:IntelliJ as it was copy-pasted from VS Code. Also there were comments on the doc about the this text that were not taken into account.

@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/intellij-walkthrough branch from 80688ca to e8912dd Compare February 28, 2025 15:39
@nquinquenel nquinquenel force-pushed the feature/ef/intellij-walkthrough branch from 76884e2 to 0e1352c Compare March 6, 2025 08:45
nquinquenel
nquinquenel approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@nquinquenel nquinquenel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/intellij-walkthrough branch from 740438c to e5b0a89 Compare March 6, 2025 13:48
@eray-felek-sonarsource eray-felek-sonarsource force-pushed the feature/ef/intellij-walkthrough branch from e5b0a89 to 92342df Compare March 6, 2025 14:09
@sonarqube-next SonarQube-Next
Copy link

sonarqube-next bot commented Mar 6, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
1 Fixed issue
0 Accepted issues

Measures
0 Security Hotspots
8.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@eray-felek-sonarsource eray-felek-sonarsource merged commit 495161f into master Mar 6, 2025
29 checks passed
@eray-felek-sonarsource eray-felek-sonarsource deleted the feature/ef/intellij-walkthrough branch March 6, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nquinquenel nquinquenel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eray-felek-sonarsource @nquinquenel