SLI-378 Prefer PasswordSafe to PasswordUtil #858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damien-urruty-sonarsource
force-pushed
the
fix/dam/SLI-378-prefer-passwordsafe
branch
9 times, most recently
from
064e677 to
bbc1101
Compare
|
0.0% Coverage on New Code
0.0% Duplication on New Code
nquinquenel
reviewed
Nov 2, 2023
| } | ||
|
|
||
| private fun loadCredentials(connectionId: String): ServerConnectionCredentials? { | ||
| val token = PasswordSafe.instance.getPassword(tokenCredentials(connectionId)) |
There was a problem hiding this comment.
This is a slow operation and it should not be run on the EDT 😢
This is especially annoying because it is called from each IssueNode when rendering
2 stack traces I got:
2023-11-02 11:06:53,403 [ 22494] SEVERE - #c.i.u.SlowOperations - Slow operations are prohibited on EDT. See SlowOperations.assertSlowOperationsAreAllowed javadoc.
java.lang.Throwable: Slow operations are prohibited on EDT. See SlowOperations.assertSlowOperationsAreAllowed javadoc.
at com.intellij.openapi.diagnostic.Logger.error(Logger.java:376)
at com.intellij.util.SlowOperations.assertNonCancelableSlowOperationsAreAllowed(SlowOperations.java:115)
at com.intellij.ide.passwordSafe.impl.BasePasswordSafe.get(PasswordSafeImpl.kt:93)
at com.intellij.credentialStore.CredentialStore.getPassword(CredentialStore.java:30)
at org.sonarlint.intellij.config.global.ServerConnectionService.loadCredentials(ServerConnectionService.kt:128)
at org.sonarlint.intellij.config.global.ServerConnectionService.getConnections(ServerConnectionService.kt:52)
at org.sonarlint.intellij.core.ProjectBindingManager.tryGetServerConnection(ProjectBindingManager.java:148)
at org.sonarlint.intellij.ui.nodes.IssueNode.retrieveServerConnection(IssueNode.java:59)
at org.sonarlint.intellij.ui.nodes.IssueNode.doRender(IssueNode.java:71)
at org.sonarlint.intellij.ui.nodes.IssueNode.lambda$render$0(IssueNode.java:67)
[...]
at org.sonarlint.intellij.common.ui.ReadActionUtils$Companion.runReadActionSafely(ReadActionUtils.kt:34)
at org.sonarlint.intellij.common.ui.ReadActionUtils.runReadActionSafely(ReadActionUtils.kt)
at org.sonarlint.intellij.ui.nodes.IssueNode.render(IssueNode.java:67)
at org.sonarlint.intellij.ui.tree.TreeCellRenderer.customizeCellRenderer(TreeCellRenderer.java:37)
[...]
at org.sonarlint.intellij.core.ProjectBindingManager.bindTo(ProjectBindingManager.java:188)
at org.sonarlint.intellij.config.project.SonarLintProjectSettingsPanel.save(SonarLintProjectSettingsPanel.java:105)
at org.sonarlint.intellij.config.project.SonarLintProjectConfigurable.apply(SonarLintProjectConfigurable.java:96)
2023-11-02 11:06:44,520 [ 13611] SEVERE - #c.i.u.SlowOperations - Slow operations are prohibited on EDT. See SlowOperations.assertSlowOperationsAreAllowed javadoc.
java.lang.Throwable: Slow operations are prohibited on EDT. See SlowOperations.assertSlowOperationsAreAllowed javadoc.
at com.intellij.openapi.diagnostic.Logger.error(Logger.java:376)
at com.intellij.util.SlowOperations.assertNonCancelableSlowOperationsAreAllowed(SlowOperations.java:115)
at com.intellij.ide.passwordSafe.impl.BasePasswordSafe.get(PasswordSafeImpl.kt:93)
at com.intellij.credentialStore.CredentialStore.getPassword(CredentialStore.java:30)
at org.sonarlint.intellij.config.global.ServerConnectionService.loadCredentials(ServerConnectionService.kt:128)
at org.sonarlint.intellij.config.global.ServerConnectionService.getConnections(ServerConnectionService.kt:52)
at org.sonarlint.intellij.config.global.ServerConnectionService.connectionExists(ServerConnectionService.kt:76)
at org.sonarlint.intellij.config.project.SonarLintProjectBindPanel.onConnectionSelected(SonarLintProjectBindPanel.java:158)
at org.sonarlint.intellij.config.project.SonarLintProjectBindPanel$ServerItemListener.itemStateChanged(SonarLintProjectBindPanel.java:415)
There was a problem hiding this comment.
😡 I did not face it on my side... Thanks for testing, I will have to rework the PR then, I will ping you when it's done
damien-urruty-sonarsource
force-pushed
the
fix/dam/SLI-378-prefer-passwordsafe
branch
from
bbc1101 to
421df9e
Compare
damien-urruty-sonarsource
force-pushed
the
fix/dam/SLI-378-prefer-passwordsafe
branch
from
421df9e to
4e749ec
Compare
|
This PR has diverged too much from master since it was created. There are many changes, not only about the main goal of the ticket. It would be risky to rebase it, better start from scratch and only integrate required changes |
damien-urruty-sonarsource
deleted the
fix/dam/SLI-378-prefer-passwordsafe
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.