Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Angular injectQueries fixes #8690

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[WIP] Angular injectQueries fixes #8690

wants to merge 4 commits into from

Conversation

crutchcorn
Copy link
Member

@crutchcorn crutchcorn commented Feb 22, 2025 •
edited
Loading

This PR:

  • Fixes the types of injectQueries
  • Add type tests for injectQueries
  • Adds initial tests for injectQueries runtime
  • Fixes runtime behavior of injectQueries

TODO:

  • Figure out where to add signalProxy

@crutchcorn crutchcorn requested a review from arnoud-dv February 22, 2025 23:18
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 22, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 3f2fc90.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 4m 13s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 3s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-22 23:25:04 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Feb 22, 2025

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8690

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8690

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8690

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8690

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8690

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8690

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8690

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8690

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8690

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8690

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8690

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8690

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8690

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8690

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8690

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8690

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8690

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8690

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8690

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8690

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8690

commit: 3f2fc90

@github-actions GitHub Actions
Copy link

Sizes for commit 3f2fc90:

Branch Bundle Size
Main
This PR

@arnoud-dv arnoud-dv mentioned this pull request Feb 26, 2025
Open
@Timebutt
Copy link

Hey @crutchcorn! I just noticed you dropped a PR to fix injectQueries. I've been using a custom build of @tanstack/angular-query-experimental from this PR (#8007) that has been working great for me in production, as I really needed injectQueries for my application.

I'm not sure if that MR can serve as an inspiration for your work, or possibly even avoid work altogether?

@arnoud-dv
Copy link
Collaborator

arnoud-dv commented Mar 7, 2025 •
edited
Loading

Should be something like this to proxify the individual queries, but I'm getting errors. I will look into this more.

    const resultSignal = computed(() => {
      const subscriberResult = resultFromSubscriberSignal()
      const optimisticResult = optimisticCombinedResultSignal()
      return subscriberResult ?? optimisticResult
    })

    return computed(() => {
      const result = resultSignal()
      if (Array.isArray(result)) {
        return result.map((query) => signalProxy(query))
      }
      return result
    })

  }) as unknown as Signal<TCombinedResult>

@arnoud-dv
Copy link
Collaborator

More todos:

[ ] Should be able to throw an error when throwOnError is true
[ ] Using map on result gives error TS2339: Property map does not exist on type TCombinedResult.
[ ] The computed with proxified queries needs to be improved so that new signals are not created for each query when the result changes.

@arnoud-dv arnoud-dv mentioned this pull request Mar 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnoud-dv arnoud-dv

Assignees
No one assigned
Labels
package: angular-query-experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crutchcorn @Timebutt @arnoud-dv