test(query-core): add test case for ensureQueryFn with skipToken #8725

manudeli · 2025-03-01T08:55:51Z

No description provided.

nx-cloud · 2025-03-01T08:56:16Z

View your CI Pipeline Execution ↗ for commit b040b49.

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	6m 14s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1m 58s	View ↗

☁️ Nx Cloud last updated this comment at 2025-03-08 09:41:30 UTC

pkg-pr-new · 2025-03-01T08:59:26Z

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8725

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8725

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8725

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8725

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8725

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8725

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8725

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8725

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8725

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8725

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8725

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8725

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8725

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8725

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8725

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8725

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8725

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8725

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8725

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8725

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8725

commit: b040b49

codecov · 2025-03-01T09:01:41Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.22%. Comparing base (4140898) to head (b040b49).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #8725       +/-   ##
===========================================
+ Coverage   46.39%   62.22%   +15.83%     
===========================================
  Files         199      121       -78     
  Lines        7551     4543     -3008     
  Branches     1729     1312      -417     
===========================================
- Hits         3503     2827      -676     
+ Misses       3668     1483     -2185     
+ Partials      380      233      -147

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`88.65% <ø> (ø)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`94.43% <100.00%> (+0.06%)`	⬆️
@tanstack/query-devtools	`4.78% <ø> (ø)`
@tanstack/query-persist-client-core	`57.73% <ø> (ø)`
@tanstack/query-sync-storage-persister	`84.61% <ø> (ø)`
@tanstack/react-query	`95.42% <ø> (ø)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`∅ <ø> (∅)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`87.33% <ø> (ø)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`100.00% <ø> (ø)`
@tanstack/vue-query	`71.01% <ø> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

TkDodo · 2025-03-01T09:17:42Z

I don’t think we should allow running an imperative function with a skipToken. There’s no enabled:boolean for those, either.

A better fix would be to get a type error if this is attempted.

manudeli · 2025-03-01T11:56:45Z

I don’t think we should allow running an imperative function with a skipToken. There’s no enabled:boolean for those, either.

A better fix would be to get a type error if this is attempted.

@TkDodo I reflect your review in 274378a

…ureQueryFn-skipToken

TkDodo · 2025-03-08T09:54:48Z

sorry, I don’t see how this addresses the issue. My point was that users shouldn’t be able to call queryClient.ensureQueryData with a queryFn that contains a skipToken. For that, we need to change the typings on the imperative functions on the queryClient. Then, we would need type tests to make sure that we can’t pass skipToken to them. So, no test that asserts the runtime log should be made because users shouldn’t be able to call it this way.

test(query-core): add test case for ensureQueryFn with skipToken

9cc4236

github-actions bot added the package: query-core label Mar 1, 2025

manudeli added 2 commits March 1, 2025 18:58

Merge branch 'main' into query-core/test/ensureQueryFn-skipToken

53391c7

chore: reflect review

274378a

manudeli force-pushed the query-core/test/ensureQueryFn-skipToken branch from 9dd6ce2 to 274378a Compare March 1, 2025 11:39

manudeli added 3 commits March 2, 2025 01:25

chore: update

b5884bb

Merge remote-tracking branch 'upstream/main' into query-core/test/ens…

e716adc

…ureQueryFn-skipToken

Merge branch 'main' into query-core/test/ensureQueryFn-skipToken

b040b49

TkDodo closed this Mar 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test(query-core): add test case for ensureQueryFn with skipToken #8725

test(query-core): add test case for ensureQueryFn with skipToken #8725

manudeli commented Mar 1, 2025

nx-cloud bot commented Mar 1, 2025 •

edited

Loading

pkg-pr-new bot commented Mar 1, 2025 •

edited

Loading

codecov bot commented Mar 1, 2025 •

edited

Loading

TkDodo commented Mar 1, 2025

manudeli commented Mar 1, 2025

TkDodo commented Mar 8, 2025

test(query-core): add test case for ensureQueryFn with skipToken #8725

test(query-core): add test case for ensureQueryFn with skipToken #8725

Conversation

manudeli commented Mar 1, 2025

nx-cloud bot commented Mar 1, 2025 • edited Loading

pkg-pr-new bot commented Mar 1, 2025 • edited Loading

codecov bot commented Mar 1, 2025 • edited Loading

Codecov Report

TkDodo commented Mar 1, 2025

manudeli commented Mar 1, 2025

TkDodo commented Mar 8, 2025

nx-cloud bot commented Mar 1, 2025 •

edited

Loading

pkg-pr-new bot commented Mar 1, 2025 •

edited

Loading

codecov bot commented Mar 1, 2025 •

edited

Loading