Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(query-core): add hashQueryKeyByOptions test code #8736

Merged
merged 7 commits into from
Mar 11, 2025
Merged

test(query-core): add hashQueryKeyByOptions test code #8736

merged 7 commits into from
Mar 11, 2025
+24 −1

Conversation

dngur9801
Copy link
Contributor

No description provided.

TkDodo
TkDodo reviewed Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@TkDodo TkDodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn’t test the byOptions part, because options are never passed to hashQueryKeyByOptions in these tests.

so this is essentially the same as #8735 right now

@dngur9801
Copy link
Contributor Author

I modified the test code to verify that when the queryKeyHashFn option is provided, the specified hash function is called, and when it is not, the default hashKey function is used.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Mar 5, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit f903afc.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 4m 45s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 2m 2s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-11 17:32:17 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Mar 5, 2025 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8736

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8736

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8736

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8736

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8736

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8736

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8736

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8736

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8736

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8736

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8736

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8736

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8736

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8736

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8736

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8736

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8736

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8736

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8736

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8736

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8736

commit: f903afc

@TkDodo
Copy link
Collaborator

TkDodo commented Mar 5, 2025

please fix eslint

@dngur9801
Copy link
Contributor Author

I fixed it! Thank you

@codecov Codecov
Copy link

codecov bot commented Mar 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.20%. Comparing base (79608f3) to head (f903afc).
Report is 5 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8736       +/-   ##
===========================================
+ Coverage   46.37%   63.20%   +16.82%     
===========================================
  Files         199      135       -64     
  Lines        7551     4854     -2697     
  Branches     1730     1370      -360     
===========================================
- Hits         3502     3068      -434     
+ Misses       3669     1541     -2128     
+ Partials      380      245      -135
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.65% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 94.31% <ø> (ø)
@tanstack/query-devtools 4.78% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.42% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.01% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TkDodo TkDodo merged commit e86c395 into TanStack:main Mar 11, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TkDodo TkDodo

Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dngur9801 @TkDodo