Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace environment variables with package.json entries #287

Merged
merged 3 commits into from
Oct 17, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: replace environment variables with package.json entries
According to `actions/node-setup`, it will read `manifest.engine` values
to decide what node version to use. Second, the lockfile path is only
relevant if it is non-default.
  • Loading branch information
jbergstroem committed Oct 17, 2024
commit 8e9dcddd3a96241bb403a2e82031049dd6cee5de
8 changes: 0 additions & 8 deletions .github/workflows/checkpr.yml
Original file line number Diff line number Diff line change
@@ -10,10 +10,6 @@ on:
branches:
- main

env:
lockfile: pnpm-lock.yaml
node_version: "18"

# This is to avoid running multiple actions when a PR is updated repeatedly. See
# https://docs.github.com/en/actions/using-jobs/using-concurrency
concurrency:
@@ -34,9 +30,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: ${{ env.node_version }}
cache: pnpm
cache-dependency-path: ${{ env.lockfile }}

- name: Install dependencies
run: pnpm install
@@ -60,9 +54,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: ${{ env.node_version }}
cache: pnpm
cache-dependency-path: ${{ env.lockfile }}

- name: Install dependencies
run: pnpm install
6 changes: 0 additions & 6 deletions .github/workflows/publish-to-npm.yml
Original file line number Diff line number Diff line change
@@ -4,10 +4,6 @@ on:
release:
types: [published]

env:
lockfile: pnpm-lock.yaml
node_version: "18"

jobs:
npm-publish:
name: Publish to NPM
@@ -24,9 +20,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: ${{ env.node_version }}
cache: pnpm
cache-dependency-path: ${{ env.lockfile }}

- name: Install dependencies
run: pnpm install
5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -4,8 +4,11 @@
"description": "JS library to automatically report events to Topsort's Analytics",
"main": "dist/ts.js",
"type": "module",
"packageManager": "pnpm@9.1.1",
"packageManager": "pnpm@9.9.0",
"keywords": ["ads", "sponsored listings", "auctions", "analytics", "topsort"],
"engines": {
"node": ">=20"
},
"exports": {
".": {
"import": "./dist/ts.mjs",