Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if all comments are hidden, no comments (not even hidden ones) are visible #22331

Open
1 task done
cathysarisky opened this issue Mar 3, 2025 · 1 comment
Open
1 task done
Labels
needs:triage [triage] this needs to be triaged by the Ghost team

Comments

@cathysarisky
Copy link
Contributor

Issue Summary

If all comments have been hidden by a site admin, the hidden comments do not appear. Making a new visible comment restores access to the hidden comments.

Steps to Reproduce

Make some comments
As a site admin, hide all the comments on a post.
Reload. Observe that the hidden comments are not displayed to the admin user.

Ghost Version

5.110.2

Node.js Version

20

How did you install Ghost?

local dev

Database type

SQLite3

Browser & OS version

windows 11, chrome

Relevant log / error output

Code of Conduct

  • I agree to be friendly and polite to people in this repository
@github-actions github-actions bot added the needs:triage [triage] this needs to be triaged by the Ghost team label Mar 3, 2025
@cathysarisky
Copy link
Contributor Author

Ahha. We have here a chicken and egg problem. The auth frame doesn't load if there are no comments, which means we never check to see if there are admin comments, because we never realize we have an admin. But we can't check for hidden comments without having the auth frame loaded, so... my best thinking today is that the auth frame should just always try to load. Otherwise, hiding the last comment on a post makes it impossible to revert the hiding, unless you make a visible comment first...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:triage [triage] this needs to be triaged by the Ghost team
Projects
None yet
Development

No branches or pull requests

1 participant