-
-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved russian translation #22259
base: main
Are you sure you want to change the base?
Improved russian translation #22259
Conversation
WalkthroughThis pull request updates several Russian localization files within the Ghost repository. In the Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
ghost/i18n/locales/ru/newsletter.json (1)
11-11
: Simplified "More like this" Translation
The key"More like this"
has been changed from a more descriptive phrase to simply"Больше"
. Verify that this shorter version still conveys the intended meaning in the given UI context and does not lose important contextual cues.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
ghost/i18n/locales/ru/comments.json
(2 hunks)ghost/i18n/locales/ru/ghost.json
(1 hunks)ghost/i18n/locales/ru/newsletter.json
(1 hunks)ghost/i18n/locales/ru/portal.json
(1 hunks)ghost/i18n/locales/ru/search.json
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- ghost/i18n/locales/ru/search.json
🔇 Additional comments (6)
ghost/i18n/locales/ru/ghost.json (3)
11-14
: Enhanced Formality in Greetings and Instructions
Lines 11–14 update the casual "Hey there" greetings and related instructions to a more formal style, using"Здравствуйте,"
and clarifying the call-to-action. This change improves consistency and professionalism.
16-16
: Refined Sign-off Message
The translation for"See you soon!"
has been updated to"До скорой встречи!"
, which preserves a friendly tone while adhering to a more formal register.
19-21
: Streamlined Sign In and Signup Confirmations
The modifications on lines 19 and 21 simplify the sign in and signup confirmation messages (e.g.,"Войти в {{siteTitle}}"
and"Спасибо за регистрацию в {{siteTitle}}!"
). This concise phrasing should help avoid any potential ambiguity while maintaining formal language standards.ghost/i18n/locales/ru/comments.json (2)
4-5
: Concise Time Phrases Revision
The changes on lines 4 and 5 replace longer expressions like"{{amount}} часа(ов) назад"
with the more concise"{{amount}} ч. назад"
and"{{amount}} мин. назад"
. These shorter forms improve brevity while still informing the user; please confirm that this level of abbreviation is clear within context.
35-35
: Standardized Generic Name Translation
Updating"Jamie Larson"
to"Полное имя"
ensures consistency with similar changes in other localization files. Double-check that this generic term is acceptable for all contexts and does not inadvertently remove essential context for users.ghost/i18n/locales/ru/portal.json (1)
100-100
: Consistent Name Translation Update
The key"Jamie Larson"
has been updated to"Полное имя"
, matching the change in the comments localization file. This standardization streamlines the user interface; please ensure that the generic phrasing meets your localization guidelines across the application.
@@ -32,7 +32,7 @@ | |||
"Hidden for members": "Скрыто для участников", | |||
"Hide": "Скрыть", | |||
"Hide comment": "Скрыть комментарий", | |||
"Jamie Larson": "Павел Бид", | |||
"Jamie Larson": "Полное имя", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not going to be acceptable to the core dev team, where there are strong feelings about having the placeholder be a name, not the words "full name". So we want something that is recognizably a name. Ideally gender neutral, but that's not possible in some languages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with @cathysarisky
@@ -97,7 +97,7 @@ | |||
"In the event a permanent failure is received when attempting to send a newsletter, emails will be disabled on the account.": "В случае возникновения постоянной ошибки при попытке отправки рассылки — электронные письма будут отключены для данной учётной записи и указанного email адреса.", | |||
"In your email client add {{senderEmail}} to your contacts list. This signals to your mail provider that emails sent from this address should be trusted.": "В вашем почтовом клиенте/приложении добавьте {{senderEmail}} в список контактов. Это скорее всего сигнализирует вашему почтовому провайдеру, что письмам, отправленным с этого адреса, следует доверять.", | |||
"Invalid email address": "Неправильный email адрес", | |||
"Jamie Larson": "Павел Бид", | |||
"Jamie Larson": "Полное имя", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see previous comment
Hey @hide-me , @kazanec18, @greatUzumaki , do you have time to review these proposed changes to the Russian Ghost translations? Thank you! |
First of all, thank you for the contribution. I believe you want to improve the translation! Some of the suggested corrections do look appropriate and fit the context better than the existing translation. On the other hand, some corrections do not improve the quality and consistency of the translation. |
This is perhaps not as useful as it could be. Can you identify which translations you think are better/worse? Thanks. :) |
@cathysarisky I commented every change. |
That's odd. I'm not seeing any comments except the general one and the one I just quoted above. Did you perhaps forget to click "Finish review" after you made your comments? (I have made this mistake many times...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -5,5 +5,5 @@ | |||
"Posts": "Записи", | |||
"Search posts, tags and authors": "Поиск по записям, тегам и авторам", | |||
"Show more results": "Показать больше результатов", | |||
"Tags": "Теги" | |||
"Tags": "Тэги" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Тег
is right version of this word
https://ru.wikipedia.org/wiki/%D0%A2%D0%B5%D0%B3#cite_note-1
@@ -8,7 +8,7 @@ | |||
"Less like this": "Меньше такого", | |||
"Manage subscription": "Управление подпиской", | |||
"Member since": "Участник с", | |||
"More like this": "Больше такого", | |||
"More like this": "Больше", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both options are acceptable, but my option seems a little closer to original. The proposed option is more universal and therefore more vague.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Context: it's a label for a "thumbs up" button in email, to tell the writer that you like their newsletter.
"Thank you for subscribing to {{siteTitle}}!": "Спасибо за подписку на {{siteTitle}}!", | ||
"Thank you for subscribing to {{siteTitle}}.": "Спасибо за подписку на {{siteTitle}}.", | ||
"Thank you for subscribing to {{siteTitle}}. Tap the link below to be automatically signed in:": "Спасибо за подписку на {{siteTitle}}. Нажмите на ссылку ниже, чтобы автоматически войти:", | ||
"This email address will not be used.": "Этот email адрес не будет использоваться.", | ||
"Welcome back to {{siteTitle}}!": "Добро пожаловать на {{siteTitle}}, с возвращением!", | ||
"Welcome back! Use this link to securely sign in to your {{siteTitle}} account:": "С возвращением! Используйте эту ссылку для безопасного входа в свою учётную запись на {{siteTitle}}:", | ||
"Welcome back to {{siteTitle}}!": "Добро пожаловать в {{siteTitle}}, с возвращением!", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
на
instead of в
because we could say it similar to "Welcome to site", not "Welcome in site"
"Welcome back to {{siteTitle}}!": "Добро пожаловать на {{siteTitle}}, с возвращением!", | ||
"Welcome back! Use this link to securely sign in to your {{siteTitle}} account:": "С возвращением! Используйте эту ссылку для безопасного входа в свою учётную запись на {{siteTitle}}:", | ||
"Welcome back to {{siteTitle}}!": "Добро пожаловать в {{siteTitle}}, с возвращением!", | ||
"Welcome back! Use this link to securely sign in to your {{siteTitle}} account:": "С возвращением! Используйте эту ссылку для входа в свой аккаунт в {{siteTitle}}:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is "securely"? :) anyway to common user both options are acceptable
"See you soon!": "До скорой встречи!", | ||
"Sent to {{email}}": "Отправлено на {{email}}", | ||
"Sign in": "Войти", | ||
"Sign in to {{siteTitle}}": "Войти на {{siteTitle}}", | ||
"Sign in to {{siteTitle}}": "Войти в {{siteTitle}}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
на instead of в because we could say it similar to "Welcome to site", not "Welcome in site"
"Tap the link below to complete the signup process for {{siteTitle}}, and be automatically signed in:": "Нажмите на ссылку ниже, чтобы завершить процесс регистрации на {{siteTitle}} и автоматически войти:", | ||
"Thank you for signing up to {{siteTitle}}!": "Спасибо за регистрацию на {{siteTitle}}!", | ||
"Thank you for signing up to {{siteTitle}}!": "Спасибо за регистрацию в {{siteTitle}}!", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
на instead of в because we could say it similar to "Welcome to site", not "Welcome in site"
"Hey there!": "Привет!", | ||
"If you did not make this request, you can safely ignore this email.": "Если вы этого не делали, можете смело игнорировать это письмо.", | ||
"If you did not make this request, you can simply delete this message.": "Если вы этого не делали, можете просто удалить это сообщение.", | ||
"Hey there,": "Здравствуйте,", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It depends what it should be: more official or more informal and friendly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, we're aiming for a friendly and informal tone.
@@ -32,7 +32,7 @@ | |||
"Hidden for members": "Скрыто для участников", | |||
"Hide": "Скрыть", | |||
"Hide comment": "Скрыть комментарий", | |||
"Jamie Larson": "Павел Бид", | |||
"Jamie Larson": "Полное имя", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with @cathysarisky
@@ -1,8 +1,8 @@ | |||
{ | |||
"{{amount}} characters left": "{{amount}} символа(ов) осталось", | |||
"{{amount}} comments": "{{amount}} комментария(ев)", | |||
"{{amount}} hrs ago": "{{amount}} часа(ов) назад", | |||
"{{amount}} mins ago": "{{amount}} минут(ы) назад", | |||
"{{amount}} hrs ago": "{{amount}} ч. назад", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, better than mine option!
"{{amount}} hrs ago": "{{amount}} часа(ов) назад", | ||
"{{amount}} mins ago": "{{amount}} минут(ы) назад", | ||
"{{amount}} hrs ago": "{{amount}} ч. назад", | ||
"{{amount}} mins ago": "{{amount}} мин. назад", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, better than mine option!
Yes... I forgot >_< |
Thank you @hide-me for reviewing! @corporatemail12121 , when you and @hide-me are in agreement that the PR is ready to merge, please @ me and I'll get it into the queue. :) |
@corporatemail12121 are you ready to change some several controversial string? |
I think this is better translation