fix:link-docs-missing #22262

abhishek-kumar-91 · 2025-02-23T01:31:30Z

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!
pr: #22141
before redirect to https://ghost.org/

Edit Tier Page
this pr redirect to
I have added this link https://ghost.org/help/free-trials/

There's a clear use-case for this code change, explained below
Commit message has a short title & references relevant issues
The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

Signed-off-by: Abhishek Kumar <abhishekkumar958830@gmail.com>

coderabbitai · 2025-02-23T01:31:37Z

Walkthrough

The change updates a hyperlink within a modal component associated with membership tiers in the admin settings. Specifically, the URL provided in a hint text of a text field has been changed from the original address to a new one that directs users to more detailed information about free trials. The functionality of the component, including the logic tied to enabling or disabling the text field based on the free trial state, remains unchanged. No changes were made to the declarations of any exported or public entities.

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/admin-x-settings/src/components/settings/membership/tiers/TierDetailModal.tsx

Oops! Something went wrong! :(

ESLint: 8.44.0

ESLint couldn't find the plugin "eslint-plugin-react-hooks".

(The package "eslint-plugin-react-hooks" was not found when loaded as a Node module from the directory "/apps/admin-x-settings".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react-hooks@latest --save-dev

The plugin "eslint-plugin-react-hooks" was referenced from the config file in "apps/admin-x-settings/.eslintrc.cjs".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a000234 and 4feccd4.

📒 Files selected for processing (1)

apps/admin-x-settings/src/components/settings/membership/tiers/TierDetailModal.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

apps/admin-x-settings/src/components/settings/membership/tiers/TierDetailModal.tsx

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

cathysarisky · 2025-02-23T01:41:11Z

apps/admin-x-settings/src/components/settings/membership/tiers/TierDetailModal.tsx

@@ -268,7 +268,7 @@ const TierDetailModalContent: React.FC<{tier?: Tier}> = ({tier}) => {
                                <TextField
                                    disabled={!hasFreeTrial}
                                    hint={<div className='mt-1'>
-                                    Members will be subscribed at full price once the trial ends. <a className='text-green' href="https://ghost.org/" rel="noreferrer" target="_blank">Learn more</a>
+                                    Members will be subscribed at full price once the trial ends. <a className='text-green' href=" https://ghost.org/help/free-trials/" rel="noreferrer" target="_blank">Learn more</a>


looks like there's an accidental space in front of the href, but otherwise looks good to me! :)

cathysarisky · 2025-03-07T12:55:14Z

Hey @abhishek-kumar-91 , just a note that there's still an extra space in the url that needs fixing. If you made the change but didn't sync your changes to Github, please do! :)

…o fix/link-docs-missing

abhishek-kumar-91 · 2025-03-10T04:03:19Z

Hey @cathysarisky , I have just removed the extra space from the link.

fix:link-docs-missing

a000234

Signed-off-by: Abhishek Kumar <abhishekkumar958830@gmail.com>

cathysarisky reviewed Feb 23, 2025

View reviewed changes

abhishek-kumar-91 added 2 commits March 10, 2025 09:25

Merge branch 'main' of https://github.com/abhishek-kumar-91/Ghost int…

78331d2

…o fix/link-docs-missing

Fix: Extra space remove from the link

4feccd4

Merge branch 'main' into fix/link-docs-missing

4a9a50c

9larsons merged commit f315c27 into TryGhost:main Mar 10, 2025
22 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix:link-docs-missing #22262

fix:link-docs-missing #22262

abhishek-kumar-91 commented Feb 23, 2025 •

edited

Loading

coderabbitai bot commented Feb 23, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

cathysarisky Feb 23, 2025

cathysarisky commented Mar 7, 2025

abhishek-kumar-91 commented Mar 10, 2025

fix:link-docs-missing #22262

fix:link-docs-missing #22262

Conversation

abhishek-kumar-91 commented Feb 23, 2025 • edited Loading

coderabbitai bot commented Feb 23, 2025 • edited Loading

Walkthrough

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

cathysarisky Feb 23, 2025

Choose a reason for hiding this comment

cathysarisky commented Mar 7, 2025

abhishek-kumar-91 commented Mar 10, 2025

abhishek-kumar-91 commented Feb 23, 2025 •

edited

Loading

coderabbitai bot commented Feb 23, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)