chore(1-3450): Place strategy names and titles on the same line (and fix list nesting issues) #9443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
thomasheartman
force-pushed
the
chore(1-3449)/release-plans-in-strategy-env
branch
from
90b000f to
7bb204a
Compare
thomasheartman
changed the title
thomasheartman
commented
Mar 7, 2025
frontend/src/component/common/StrategyItemContainer/StrategyItemContainer.tsx
Outdated
Show resolved
Hide resolved
| const StyledHeaderContainer = styled('hgroup')(({ theme }) => ({ | ||
| display: 'flex', | ||
| flexFlow: 'row', | ||
| columnGap: '1ch', |
There was a problem hiding this comment.
Approximates one space.
frontend/src/component/common/StrategyItemContainer/StrategyItemContainer.tsx
Show resolved
Hide resolved
Comment on lines
+255
to
+258
| <li> | ||
| {releasePlans.length > 0 ? ( | ||
| <StrategySeparator /> | ||
| ) : null} |
There was a problem hiding this comment.
Nest nested lists within list items and add the separator between release plans and strategies to this element instead of the first strategy.
Emetion complains that: > The pseudo class :first-child is potentially unsafe when doing server-side rendering. Try changing it to :first-of-type. First of type won't work, so use classes instead.
thomasheartman
changed the title
thomasheartman
commented
Mar 7, 2025
Comment on lines
+44
to
+56
| '& > li': { | ||
| paddingBlock: theme.spacing(2.5), | ||
| position: 'relative', | ||
| }, | ||
| '&:not(li > &) > li:first-of-type': { | ||
| // select first list elements in lists that are not directly nested | ||
| // within other lists. | ||
| paddingTop: theme.spacing(1), | ||
| }, | ||
| '& > li:has(> ol)': { | ||
| // nested lists add their own padding to their list items, so we don't want to double it up. | ||
| paddingBlock: 0, | ||
| }, |
There was a problem hiding this comment.
Yay, CSS selectors 🥳 I moved all the li spacing and positioning up here so that it's colocated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves strategy titles and names onto the same line, as per the new designs.
In doing so, I've also updated the component to use a more semantic hgroup with the header being the strategy title if it exists or the strategy name if not.
The downside of being more semantically correct here is that we need to know what header level we want the strategy to use. In most cases, that's 3 (e.g. flag name > environment > strategy, release plan > milestone > strategy), but for plans on flag envs, it's 4 (flag name > env > milestone name > strategy).
I've also taken the opportunity to fix a little mistake I made earlier.
ols can only havelichildren, and I'd forgotten to wrap a nestedolinside anli. The changes inEnvironmentAccordionBodyall relate to that change. Because we now have several layers of lists nested within each other, dealing with styling and padding gets a little tricky, but CSS has the power do help us out here.Rendered:
