Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(1.98): update patches #2244

Merged
merged 20 commits into from
Mar 8, 2025
Merged

feat(1.98): update patches #2244

merged 20 commits into from
Mar 8, 2025

Conversation

daiyam
Copy link
Member

@daiyam daiyam commented Mar 5, 2025

No description provided.

@daiyam
Copy link
Member Author

daiyam commented Mar 5, 2025

I'm getting the following errors:

npm error In file included from ../src/keymapping.cc:7:
npm error In file included from /Users/baptiste/Library/Caches/node-gyp/34.2.0/include/node/node.h:79:
npm error In file included from /Users/baptiste/Library/Caches/node-gyp/34.2.0/include/node/v8.h:24:
npm error In file included from /Users/baptiste/Library/Caches/node-gyp/34.2.0/include/node/v8-array-buffer.h:13:
npm error /Users/baptiste/Library/Caches/node-gyp/34.2.0/include/node/v8-memory-span.h:44:36: error: no member named 'enable_view' in namespace 'std::ranges'
npm error inline constexpr bool std::ranges::enable_view<v8::MemorySpan<T>> = true;
npm error                       ~~~~~~~~~~~~~^
npm error /Users/baptiste/Library/Caches/node-gyp/34.2.0/include/node/v8-memory-span.h:44:47: error: expected ';' at end of declaration
npm error inline constexpr bool std::ranges::enable_view<v8::MemorySpan<T>> = true;
npm error                                               ^
npm error                                               ;
npm error /Users/baptiste/Library/Caches/node-gyp/34.2.0/include/node/v8-memory-span.h:44:47: error: expected unqualified-id

It's due to an incompatibility between native-keymap and electron-v34.2.0.

@daiyam daiyam merged commit b9975ba into VSCodium:insider Mar 8, 2025
23 of 26 checks passed
@daiyam daiyam deleted the feat-198 branch March 8, 2025 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant