Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Web maps want #504

Merged
merged 4 commits into from
Jul 6, 2022
Merged

Update Web maps want #504

merged 4 commits into from
Jul 6, 2022

Conversation

prushforth
Copy link
Contributor

Add privacy and accessibility tags. Update description to be less lame. cc @nchan0154 to validate these changes, because she's co-author.

Add privacy and accessibility tags.  Update description to be less lame.  cc @nchan0154 to validate  these changes, because she's co-author.
@netlify
Copy link

netlify bot commented Oct 19, 2021

‼️ Deploy request for webwewant rejected.

Name Link
🔨 Latest commit 855705a

@nchan0154
Copy link

Always a 👍 for putting accessibility at the forefront!

Thanks for these improvements.

Co-authored-by: Robert Linder <robert.vuj.linder@outlook.com>
@prushforth
Copy link
Contributor Author

This would be great to get merged, in light of the survey. Thanks!

@prushforth
Copy link
Contributor Author

@aarongustafson please merge. If browsers are watching this space for action items, we would like to keep it fresh. Thanks

Copy link
Collaborator

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this update looks good. Would folks be open to some grammar improvements? E.g. the sentence "Web maps are often seen as used only for store locator pages."

@prushforth
Copy link
Contributor Author

@tantek thanks, of course! I don't know if what I did is what you had in mind, but if you can improve it, please have a shot at it.

Copy link
Collaborator

@tantek tantek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! LGTM. Thanks for this update.

@aarongustafson aarongustafson merged commit a3e08b7 into WebWeWant:main Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants