fix: Console editor missed printed output. #2133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit 8c13d00 fix build actions. So I guess you can rebase your PR. |
This change is to fix a bug reported in discord by berkus and Naheulf about the console missing output lines. The bug was caused by using SetText which replaces the existing text with the text in the argument. To fix it use InsertText which puts the text at the current cursor position that was already set to the end of the current contents. Code was tested with pattern used to reproduce the bug and seemed to work when evaluated repeatedly.
paxcut
force-pushed
the
ConsoleEditorEatingLinesBug
branch
from
9c98519 to
5ed8a94
Compare
|
Ok, I rebased it and is trying to build again. I don't expect any problems since this is probably one of the simplest PRs ever. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is to fix a bug reported in discord by berkus and Naheulf about the console missing output lines. The bug was caused by using SetText which replaces the existing text with the text in the argument.
To fix it use InsertText which puts the text at the current cursor position that was already set to the end of the current contents.
Code was tested with pattern used to reproduce the bug and seemed to work when evaluated repeatedly.