Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(tools): clean up github actions #224

Merged
merged 4 commits into from
Jun 29, 2024

Conversation

MrGreenTea
Copy link
Contributor

Gather all lint checks into one action and parse them with a problem-matcher. This way we make good use of the pnpm run lint script.

There are issues with setup-node default problem-matcher for eslint so we include a custom one.

Copy link

cloudflare-workers-and-pages bot commented Jun 17, 2024

Deploying website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 79bdaae
Status: ✅  Deploy successful!
Preview URL: https://6755acd8.website-7c4.pages.dev
Branch Preview URL: https://mrgreentea-ci-refactor-githu.website-7c4.pages.dev

View logs

@MrGreenTea
Copy link
Contributor Author

See this issue for the problem matcher: actions/setup-node#96 (comment)

@MrGreenTea MrGreenTea force-pushed the mrgreentea/ci/refactor-github-actions branch from ff95f32 to e6ea37c Compare June 17, 2024 08:06
@MrGreenTea MrGreenTea force-pushed the mrgreentea/ci/refactor-github-actions branch 2 times, most recently from 5a10c6d to 2bf3d1f Compare June 27, 2024 07:33
@MrGreenTea
Copy link
Contributor Author

This needs #225 to be merged first for eslint to work again.

@MrGreenTea MrGreenTea force-pushed the mrgreentea/ci/refactor-github-actions branch 2 times, most recently from 1cf764a to 394d2bd Compare June 28, 2024 09:58
Gather all lint checks into one action and parse them with a problem-matcher.
This way we make good use of the `pnpm run lint` script.

There are issues with setup-node default problem-matcher for eslint so we include a custom one.
@MrGreenTea MrGreenTea force-pushed the mrgreentea/ci/refactor-github-actions branch from 394d2bd to 79bdaae Compare June 28, 2024 10:02
@MrGreenTea MrGreenTea requested a review from Han2-Ro June 28, 2024 10:24
@MrGreenTea MrGreenTea merged commit d40a59f into main Jun 29, 2024
6 checks passed
@MrGreenTea MrGreenTea deleted the mrgreentea/ci/refactor-github-actions branch June 29, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant