Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update version getter #7

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −1
Open

update version getter #7

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
534abef
update version getter
mefengl Dec 3, 2024
b6f504b
fix end race condition
mefengl Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
update version getter 
* Replace `$('meta[itemprop="version"]').attr('content')` with the new
method querying the h2 element and finding the version in the next
sibling node of the div with content 'Version'
  • Loading branch information
@mefengl
mefengl committed Dec 3, 2024
commit 534abef388da3c4d8a12d64f3b8edc378f7804e4
2 changes: 1 addition & 1 deletion src/chromepet.js
View file
Original file line number Diff line number Diff line change
@@ -79,7 +79,7 @@ ChromePet.prototype.stopScraping = function(err, extension) {

ChromePet.prototype._parseExtensionInfo = function(body) {
var $ = cheerio.load(body);
var version = $('meta[itemprop="version"]').attr('content');
var version = $('h2:contains("Details")').closest('section').find('li div:contains("Version")').next().text();
var interactionCount = $('meta[itemprop="interactionCount"]').attr('content');

return {