Update all dependencies, conforming to the new controller-runtime API #3949
+20,315
−5,207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikola-jokic
requested review from
mumoshu,
toast-gear,
rentziass and
a team
as code owners
nikola-jokic
force-pushed
the
nikola-jokic/dep
branch
from
1121507 to
6031787
Compare
nikola-jokic
added
the
gha-runner-scale-set
rentziass
previously approved these changes
Mar 7, 2025
nikola-jokic
force-pushed
the
nikola-jokic/dep
branch
from
02cff10 to
553ac61
Compare
Link-
reviewed
Mar 10, 2025
| } | ||
|
|
||
| func (w *WorkVolumeClaimTemplate) validate() error { | ||
| if w.AccessModes == nil || len(w.AccessModes) == 0 { | ||
| return errors.New("Access mode should have at least one mode specified") | ||
| if len(w.AccessModes) == 0 { |
There was a problem hiding this comment.
What's our level of confidence with these changes?
There was a problem hiding this comment.
e2e tests are passing so I guess it should be fine 😄
|
just to be sure, @nikola-jokic once this is done and release gha-runner-scale-set-0.11.0 is out, we will be able to use custom labels with the helm chart? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes following changes:
Fixes #3943