Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: reference actions/attest by hash #486

Closed
wants to merge 1 commit into from

Conversation

sslavic
Copy link

@sslavic sslavic commented Feb 28, 2025

Fixes regression introduced since #321

See jquery/jquery#5266 for rationale (cc @gabibguti)

Signed-off-by: Stevo Slavic <sslavic@gmail.com>
@sslavic sslavic requested a review from a team as a code owner February 28, 2025 10:14
@stevo-f3 stevo-f3 mentioned this pull request Feb 28, 2025
@bdehamer
Copy link
Collaborator

@sslavic while the guidance to reference actions by hash has historically been the best practice, most of the GH first-party actions are now being published with the new Immutable Actions feature and can now safely be referenced by their tag.

@bdehamer bdehamer closed this Feb 28, 2025
@sslavic
Copy link
Author

sslavic commented Mar 3, 2025

@bdehamer please reconsider

@stevo-f3
Copy link

stevo-f3 commented Mar 6, 2025

Fixed via #493

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants