Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore action doesn't actually fail workflow even when fail-on-cache-miss is true #1369

Open
efine-vivodyne opened this issue Apr 1, 2024 · 2 comments

Comments

@efine-vivodyne
Copy link

If your issue is relevant to this repository, please delete this text and continue to create this issue. Thank you in advance.

I'm using v4.0.0 of the Restore action, and I've noticed consistently that if there's a cache miss, that the step of the workflow errors, but it does not fail the job/workflow

I get this all the time
Error: Failed to restore cache entry. Exiting as fail-on-cache-miss is set.

But then the job proceeds just fine and after it's done I see a checkmark in the "workflow summary" page for that job.

I would expect that it should fail the job right at that step as soon as the cache miss occurs

@deemp
Copy link

deemp commented Apr 3, 2024

It seems like this problem was fixed in https://github.com/actions/cache/releases/tag/v4.0.2.

@efine-vivodyne
Copy link
Author

It seems like this problem was fixed in https://github.com/actions/cache/releases/tag/v4.0.2.

Thanks! I'll try that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants