Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation is unclear about cache-hit's value when the cache misses. #1513

Open
lima-limon-inc opened this issue Dec 11, 2024 · 0 comments · May be fixed by #1514
Open

Documentation is unclear about cache-hit's value when the cache misses. #1513

lima-limon-inc opened this issue Dec 11, 2024 · 0 comments · May be fixed by #1514

Comments

@lima-limon-inc
Copy link

In some places it is stated that cache-hit evaluates to the empty string when if fails, notably here:

However this would appear to contradict this other statement:

I am assuming that the latter is a mistake and the former is the intended behavior (mainly based on the comments of the issue linked above). Is this assumption correct or am I missing something?

Is there any specific moment in the codebase where the empty string is returned? I was not able to find it. Do note that I am not too familiar with typescript. AFAIK, it would seem that the only places where cache-hit is set are:

Furthermore, are there any examples in how to handle the case when the cacheHit evaluates to the empty string? I could only find examples where that variable is tested for "true" or "false".

Thanks in advance!

lima-limon-inc added a commit to lima-limon-inc/cache that referenced this issue Dec 11, 2024
lima-limon-inc added a commit to lima-limon-inc/cache that referenced this issue Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant