Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect check of version for the deprecation #1548

Closed
BoD opened this issue Feb 11, 2025 · 1 comment
Closed

Incorrect check of version for the deprecation #1548

BoD opened this issue Feb 11, 2025 · 1 comment

Comments

@BoD
Copy link

BoD commented Feb 11, 2025

Following this annoucement, workflows automatically fail for old versions of this action.

In our workflow we reference versions by sha1 rather than by tag:

      - name: Setup Plugin Verifier IDEs Cache
        uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 #v4.0.2
        with:
          path: ${{ steps.properties.outputs.pluginVerifierHomeDir }}/ides
          key: plugin-verifier-${{ hashFiles('intellij-plugin/build/listProductsReleases.txt') }}

This is a good practice that ensures reproducible builds and avoids potential security issues.

In our case 0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 is the sha1 for v4.0.2 which, if I'm not mistaken, should not fail the build as it is recent enough. But this failed the build.

@BoD
Copy link
Author

BoD commented Feb 11, 2025

Nevermind, using 1bd1e32 (v4.2.0) as explained here did the trick.

@BoD BoD closed this as completed Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant