Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dart example #1191

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add dart example #1191

wants to merge 2 commits into from

Conversation

Yakiyo
Copy link

@Yakiyo Yakiyo commented Jun 15, 2023

Description

I've added an example for using the action within a dart repository

Motivation and Context

Faster workflows in any dart project.

How Has This Been Tested?

I've tested the same code snippet in the example in one of my projects and it ran as intended.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Yakiyo Yakiyo requested a review from a team as a code owner June 15, 2023 17:56
@nhan19977
Copy link

Uploading 1684654587068.jpg…

@nhan19977
Copy link

Nhan

@nhan19977
Copy link

Nhab

@nhan19977
Copy link

Trường Võ Văn Kiệt

@adil192
Copy link

adil192 commented Aug 1, 2023

If you use subosito/flutter-action@v2, the pub cache is in a different location:

# linux
FLUTTER_ROOT: /opt/hostedtoolcache/flutter/stable-3.10.6-x64
PUB_CACHE: /opt/hostedtoolcache/flutter/stable-3.10.6-x64/.pub-cache

# macos
FLUTTER_ROOT: /Users/runner/hostedtoolcache/flutter/stable-3.10.6-x64
PUB_CACHE: /Users/runner/hostedtoolcache/flutter/stable-3.10.6-x64/.pub-cache

# windows
FLUTTER_ROOT: C:\hostedtoolcache\windows\flutter\stable-3.10.6-x64
PUB_CACHE: C:\hostedtoolcache\windows\flutter\stable-3.10.6-x64/.pub-cache

@Yakiyo
Copy link
Author

Yakiyo commented Aug 1, 2023

If you use subosito/flutter-action@v2, the pub cache is in a different location:

# linux
FLUTTER_ROOT: /opt/hostedtoolcache/flutter/stable-3.10.6-x64
PUB_CACHE: /opt/hostedtoolcache/flutter/stable-3.10.6-x64/.pub-cache

# macos
FLUTTER_ROOT: /Users/runner/hostedtoolcache/flutter/stable-3.10.6-x64
PUB_CACHE: /Users/runner/hostedtoolcache/flutter/stable-3.10.6-x64/.pub-cache

# windows
FLUTTER_ROOT: C:\hostedtoolcache\windows\flutter\stable-3.10.6-x64
PUB_CACHE: C:\hostedtoolcache\windows\flutter\stable-3.10.6-x64/.pub-cache

Wouldnt that be because flutter packages its own version of the dart sdk wouldnt it. That would definitely differ from just using dart. Not sure wether that needs to be specified or not.

@adil192
Copy link

adil192 commented Aug 1, 2023

Wouldnt that be because flutter packages its own version of the dart sdk wouldnt it.

It's just an environment variable set by flutter-action (see the code snippet).

Not sure wether that needs to be specified or not.

Since flutter and subosito/flutter-action are quite popular, maybe a separate Flutter section should be added alongside the Dart section? I feel like just having the dart section would cause some confusion

@Yakiyo
Copy link
Author

Yakiyo commented Aug 1, 2023

Since flutter and subosito/flutter-action are quite popular, maybe a separate Flutter section should be added alongside the Dart section? I feel like just having the dart section would cause some confusion

yes, i also feel like there should be separate section for flutter but idk if this is allowed. if one of the maintainers replied maybe something could be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants