feat: bump actions/checkout to v4 #1231
Conversation
|
make sense! |
|
Closes #1260. |
kbdharun
changed the title
.github/workflows/workflow.yml
Outdated
| - name: Setup Node.js 20.x | ||
| uses: actions/setup-node@v3 | ||
| uses: actions/setup-node@v4 |
There was a problem hiding this comment.
| uses: actions/setup-node@v4 | |
| uses: actions/setup-node@v3 |
Somehow actions/setup-node is also bumped in the last commit dbe5320. But this change didn't belong to the current default branch (in upstream repo), thus I propose to revert it.
cache/.github/workflows/workflow.yml
Lines 24 to 25 in a2ed59d
There was a problem hiding this comment.
Thanks, which resolving the conflict I seem to have accidentally bumped it as the latest Node 20-based version is v4 series (reverted it, but I don't currently see other PRs bumping it). I personally think setting dependabot for updating GitHub actions would work the best for the current usage.
There was a problem hiding this comment.
I wonder why this repo didn't use a dependabot.yml to keep GitHub Actions up-to-date.
Co-authored-by: Yukai Chou <muzimuzhi@gmail.com>
Description and Context:
Node 16 reaches the end of life soon on 11 Sep 2023. This PR updates the default runtime toI have also bumped thenode20(Node 20).actions/checkoutversion to v4 for the same.Related issue:
actions/runner#2732
Closes #1260
A major version bump might be needed after the PRs merge.