Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump actions/checkout to v4 #1231

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+23 −23
Open

feat: bump actions/checkout to v4 #1231

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8070854
feat: bump to use node20 runtime, actions/checkout to v4
kbdharun Sep 5, 2023
0ccaf0f
Merge branch 'main' into main
kbdharun Oct 24, 2023
dbe5320
Merge branch 'main' into main
kbdharun Feb 2, 2024
f5f477a
revert: bump to setup-node
kbdharun Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'main' into main
  • Loading branch information
@kbdharun
kbdharun authored Feb 2, 2024
commit dbe53203465e844da30e801ee1d2cd43671f63f4
4 changes: 2 additions & 2 deletions .github/workflows/workflow.yml
View file
Original file line number Diff line number Diff line change
@@ -21,8 +21,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
- name: Setup Node.js 16.x
uses: actions/setup-node@v3
- name: Setup Node.js 20.x
uses: actions/setup-node@v4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/setup-node@v4
uses: actions/setup-node@v3

Somehow actions/setup-node is also bumped in the last commit dbe5320. But this change didn't belong to the current default branch (in upstream repo), thus I propose to revert it.

cache/.github/workflows/workflow.yml

Lines 24 to 25 in a2ed59d

- name: Setup Node.js 20.x
uses: actions/setup-node@v3

Copy link
Author

@kbdharun kbdharun Feb 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, which resolving the conflict I seem to have accidentally bumped it as the latest Node 20-based version is v4 series (reverted it, but I don't currently see other PRs bumping it). I personally think setting dependabot for updating GitHub actions would work the best for the current usage.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this repo didn't use a dependabot.yml to keep GitHub Actions up-to-date.

with:
node-version: 20.x
cache: npm
You are viewing a condensed version of this merge commit. You can view the full changes here.