Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump actions/checkout to v4 #1231

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+23 −23
Open

feat: bump actions/checkout to v4 #1231

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8070854
feat: bump to use node20 runtime, actions/checkout to v4
kbdharun Sep 5, 2023
0ccaf0f
Merge branch 'main' into main
kbdharun Oct 24, 2023
dbe5320
Merge branch 'main' into main
kbdharun Feb 2, 2024
f5f477a
revert: bump to setup-node
kbdharun Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
View file
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v3
uses: actions/checkout@v4

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
12 changes: 6 additions & 6 deletions .github/workflows/workflow.yml
View file
Original file line number Diff line number Diff line change
@@ -20,9 +20,9 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup Node.js 20.x
uses: actions/setup-node@v3
uses: actions/setup-node@v4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: actions/setup-node@v4
uses: actions/setup-node@v3

Somehow actions/setup-node is also bumped in the last commit dbe5320. But this change didn't belong to the current default branch (in upstream repo), thus I propose to revert it.

cache/.github/workflows/workflow.yml

Lines 24 to 25 in a2ed59d

- name: Setup Node.js 20.x
uses: actions/setup-node@v3

Copy link
Author

@kbdharun kbdharun Feb 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, which resolving the conflict I seem to have accidentally bumped it as the latest Node 20-based version is v4 series (reverted it, but I don't currently see other PRs bumping it). I personally think setting dependabot for updating GitHub actions would work the best for the current usage.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this repo didn't use a dependabot.yml to keep GitHub Actions up-to-date.

with:
node-version: 20.x
cache: npm
@@ -43,7 +43,7 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Generate files in working directory
shell: bash
run: __tests__/create-cache-files.sh ${{ runner.os }} test-cache
@@ -66,7 +66,7 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Restore cache
uses: ./
with:
@@ -96,7 +96,7 @@ jobs:
https_proxy: http://squid-proxy:3128
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Generate files
run: __tests__/create-cache-files.sh proxy test-cache
- name: Save cache
@@ -119,7 +119,7 @@ jobs:
https_proxy: http://squid-proxy:3128
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Restore cache
uses: ./
with:
10 changes: 5 additions & 5 deletions README.md
View file
Original file line number Diff line number Diff line change
@@ -91,7 +91,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Cache Primes
id: cache-primes
@@ -122,7 +122,7 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Restore cached Primes
id: cache-primes-restore
@@ -229,7 +229,7 @@ Example:

```yaml
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/cache@v4
id: cache
@@ -259,7 +259,7 @@ jobs:
build-linux:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Cache Primes
id: cache-primes
@@ -286,7 +286,7 @@ jobs:
build-windows:
runs-on: windows-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Cache Primes
id: cache-primes
10 changes: 5 additions & 5 deletions caching-strategies.md
View file
Original file line number Diff line number Diff line change
@@ -146,7 +146,7 @@ In case you are using a centralized job to create and save your cache that can b

```yaml
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/cache/restore@v3
id: cache
@@ -171,7 +171,7 @@ You can use the output of this action to exit the workflow on cache miss. This w

```yaml
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/cache/restore@v3
id: cache
@@ -249,7 +249,7 @@ Similarly, `actions/cache/save` action can be conditionally used based on the ou

```yaml
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
.
. // restore if need be
.
@@ -270,7 +270,7 @@ In case of multi-module projects, where the built artifact of one project needs

```yaml
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Build
run: ./build-parent-module.sh
@@ -286,7 +286,7 @@ steps:

```yaml
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/cache/restore@v3
id: cache
8 changes: 4 additions & 4 deletions restore/README.md
View file
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@ If you are using separate jobs to create and save your cache(s) to be reused by

```yaml
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/cache/restore@v3
id: cache
@@ -64,7 +64,7 @@ In case of multi-module projects, where the built artifact of one project needs

```yaml
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Build
run: /build-parent-module.sh
@@ -80,7 +80,7 @@ steps:

```yaml
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/cache/restore@v3
id: cache
@@ -107,7 +107,7 @@ To fail if there is no cache hit for the primary key, leave `restore-keys` empty

```yaml
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- uses: actions/cache/restore@v3
id: cache
4 changes: 2 additions & 2 deletions save/README.md
View file
Original file line number Diff line number Diff line change
@@ -23,7 +23,7 @@ If you are using separate jobs for generating common artifacts and sharing them

```yaml
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Install Dependencies
run: /install.sh
@@ -74,7 +74,7 @@ There are instances where some flaky test cases would fail the entire workflow a

```yaml
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
.
. // restore if need be
.
2 changes: 1 addition & 1 deletion tips-and-workarounds.md
View file
Original file line number Diff line number Diff line change
@@ -61,7 +61,7 @@ jobs:
contents: read
steps:
- name: Check out code
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Cleanup
run: |