Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note about when key is rendered #1283

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add note about when key is rendered #1283

wants to merge 1 commit into from

Conversation

IanButterworth
Copy link

@IanButterworth IanButterworth commented Nov 18, 2023 •
edited
Loading

Description

Adds a note that the key is rendered during the restore step, as it is currently not clear that this is the case.

Motivation and Context

Behavior unclear otherwise

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@IanButterworth IanButterworth requested a review from a team as a code owner November 18, 2023 18:32
@IanButterworth IanButterworth mentioned this pull request Nov 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@IanButterworth