-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update examples to v4 #1311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the comment, I was actually surprised that it all was still version 3
@@ -55,10 +55,10 @@ Using [NuGet lock files](https://docs.microsoft.com/nuget/consume-packages/packa | |||
``` | |||
|
|||
Depending on the environment, huge packages might be pre-installed in the global cache folder. | |||
With `actions/cache@v3` you can now exclude unwanted packages with [exclude pattern](https://github.com/actions/toolkit/tree/main/packages/glob#exclude-patterns) | |||
With `actions/cache@v4` you can now exclude unwanted packages with [exclude pattern](https://github.com/actions/toolkit/tree/main/packages/glob#exclude-patterns) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would argue this could be documenting functionality from the prior version. I would just say "From action/cache@v3
onwards [...]"
Thank you for this! Let me get this read through today/tomorrow :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating all our old tags :) LGTM
Thank you everyone 🙏 |
Description
These changes update all markdown documentation to use the
v4
versions of:actions/cache@v4
actions/cache/save@v4
actions/cache/restore@v4
actions/checkout@v4
These changes do not update the
.github/workflows
. Those are addressed in: #1231Motivation and Context
Up-to-date documentation improves developer happiness.
How Has This Been Tested?
Visual inspection of changes.
Screenshots (if appropriate):
Types of changes
Checklist: