Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid re-evaluation of the key input in restore implementation #1374

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

itchyny
Copy link

@itchyny itchyny commented Apr 14, 2024

Description

This PR fixes the re-evaluation of the key input for setting the cache-hit output in the restore implementation.

Motivation and Context

I noticed that the restore implementation re-evaluates the key input on setting the cache-hit output.
This does not cause any real issue, the change just refactors the code.

How Has This Been Tested?

I have run the unit tests restoreImpl.test.ts which covers the code I changed.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)
  • Refactoring (non-breaking change which does not change the behavior)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@itchyny itchyny requested a review from a team as a code owner April 14, 2024 13:56
@itchyny itchyny force-pushed the refactor-exact-key-match branch from 4e7ce9a to 5cdbd5c Compare October 5, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants