Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add releaseNewActionVersion environment gate to prevent accidental releases #1486

Closed
wants to merge 1 commit into from

Conversation

Link-
Copy link
Member

@Link- Link- commented Oct 22, 2024

Description

This pull request includes changes to the GitHub Actions workflow configuration to improve the publishing process. The most important changes are the addition of an environment for the publish job and some formatting adjustments.

Motivation and Context

We don't want accidental and non-gated releases of immutable action packages. releaseNewActionVersion is a gated environment and will require approval before release.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Link- Link- requested a review from a team as a code owner October 22, 2024 13:15
@joshmgross
Copy link
Member

cc @Jcambass - I'm curious if we should standardize this process across the actions org

@Link- Link- closed this Nov 13, 2024
@Link- Link- deleted the Link-/add-environment-gate branch November 13, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants