Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update force deletion docs due a recent deprecation #1500

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

sebbalex
Copy link
Contributor

Description

Recently the gh-actions-cache was deprecated since it has been integrated in gh CLI directly

Motivation and Context

This PR aims to update documentation accordingly these changes.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@sebbalex sebbalex requested a review from a team as a code owner November 28, 2024 13:23
@joshmgross joshmgross self-assigned this Feb 11, 2025

jobs:
cleanup:
runs-on: ubuntu-latest
permissions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this section back? I'd still recommend users explicitly define what permissions a workflow needs

@@ -49,36 +48,28 @@ on:
pull_request:
types:
- closed
workflow_dispatch:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users may still want to trigger this workflow manually

@sebbalex
Copy link
Contributor Author

Thank you @joshmgross, I applied your suggestions, could you have a look now, tnx

@joshmgross joshmgross merged commit 9fa7e61 into actions:main Feb 12, 2025
14 checks passed
@sebbalex sebbalex deleted the patch-1 branch February 18, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants