Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: GitHub is spelled incorrectly in caching-strategies.md #1526

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

janco-absa
Copy link
Contributor

Description

Update the word GiHub 3 lines under the start of that section, because it's confusing to read. It should be "GitHub"

Motivation and Context

I was reading the caching strategies and got a confused when "GiHub" was mentioned, had to to do a double take :)

How Has This Been Tested?

Nope, its only docs

Screenshots (if appropriate):

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (add or update README or docs)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

GitHub was spelled incorrectly 3 lines under the Understanding how to choose path section
@janco-absa janco-absa requested a review from a team as a code owner January 2, 2025 12:58
Copy link

@TheGiraffe3 TheGiraffe3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@joshmgross joshmgross enabled auto-merge (squash) January 6, 2025 16:53
@joshmgross joshmgross merged commit 53aa38c into actions:main Jan 6, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants