Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix cache-hit value when cache not found #876

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

fix: fix cache-hit value when cache not found #876

wants to merge 8 commits into from

Conversation

bchen1029
Copy link

related to github/docs#18524

set cache-hit to false when there is no cache matched

@bchen1029 bchen1029 requested a review from a team as a code owner July 26, 2022 07:23
@github-actions github-actions bot requested a review from bishal-pdMSFT July 26, 2022 07:23
@bchen1029
Copy link
Author

Hoping this is a major priority! thx!

@aparna-ravindra aparna-ravindra mentioned this pull request Aug 16, 2022
Merged
5 tasks
@bchen1029
Copy link
Author

@bishal-pdMSFT how to pass the CI testing? Is run npm run build and add a new commit the right approach?

@bchen1029
Copy link
Author

@vsvipul would you mind help me out with this PR and review it if you're free? really appreciate.

@vsvipul
Copy link
Contributor

vsvipul commented Aug 30, 2022

@bchen1029 Please fix the failing checks. Updating the branch and then running npm run build should fix it ig.

@bchen1029
Copy link
Author

@bchen1029 Please fix the failing checks. Updating the branch and then running npm run build should fix it ig.

@vsvipul I've fixed the checks, hoping this PR would be helpful and could be merged. Thank you very much for your help.

@bchen1029
Copy link
Author

@aparna-ravindra would you mind help approve/check this PR?

@Jimimaku
Copy link

related to github/docs#18524

set cache-hit to false when there is no cache matched

@bchen1029
Copy link
Author

@thecontemoraryflorals feel free to ping me with any suggestion for merge this PR. really appreciate.

@rgrunber rgrunber mentioned this pull request Sep 22, 2023
Open
@bchen1029 bchen1029 mentioned this pull request Oct 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thecontemoraryflorals thecontemoraryflorals

@bishal-pdMSFT bishal-pdMSFT

At least 1 approving review is required to merge this pull request.

Assignees

@bishal-pdMSFT bishal-pdMSFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bchen1029 @vsvipul @Jimimaku @thecontemoraryflorals @bishal-pdMSFT @anuragc617